[private-methods-in-controllers] prevents split helper-methods to become... #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ome actions in the Rails controllers
Member
|
Good catch, thanks again for all this code gardening! |
andrew
added a commit
that referenced
this pull request
Mar 18, 2015
[private-methods-in-controllers] prevents split helper-methods to become...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... actions in the Rails controllers
When we use Split gem with Rails we mixin Split::Helper and its methods could potentially became actions in the controllers, since it's public scope right now.
Lets make Helper methods private to prevent possible security problem, and it will also add the possibility for usage like this
Split::Helper.ab_test()