Don't check for capture presence in ab_test #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this code was previously merged, Rails has changed and currently (at 4.2) this code has not been working in controllers, because the condition was true also for capture method from Kernel::Reporting module from Rails.
Member
|
Looks good, thanks @tomasdundacek, will this break support for older versions of rails? It looks like the tests are passing on all versions, but they were also passing on rails 4.2 before hand. |
andrew
added a commit
that referenced
this pull request
May 16, 2015
Don't check for capture presence in ab_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this code was previously merged, Rails has changed and currently
(at 4.2) this code has not been working in controllers, because the
condition was true also for capture method from Kernel::Reporting module
from Rails.