Skip to content

Return an empty hash as metadata when Split is disabled #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2015
Merged

Return an empty hash as metadata when Split is disabled #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/split/helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ def ab_test(metric_descriptor, control = nil, *alternatives)
end

if block_given?
yield(alternative, (trial.metadata if trial))
metadata = trial ? trial.metadata : {}
yield(alternative, metadata)
else
alternative
end
Expand Down
11 changes: 11 additions & 0 deletions spec/helper_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,17 @@
meta
end).to eq('Meta1')
end

it 'should pass empty hash to helper block if library disabled' do
Split.configure do |config|
config.enabled = false
end

expect(ab_test('my_experiment')).to eq 'one'
expect(ab_test('my_experiment') do |_, meta|
meta
end).to eq({})
end
end

describe 'finished' do
Expand Down