Skip to content

Conversation

@dejarno
Copy link
Contributor

@dejarno dejarno commented Jan 19, 2016

Issue #173

@mgod
Copy link
Contributor

mgod commented Jan 29, 2016

This looks like it should work, but for better encapsulation, can you not add a new method to the class and instead use the existing findTokenEnd on the Tokenizer? Should make it cleaner if someone is doing some odd token work.

@dejarno
Copy link
Contributor Author

dejarno commented Feb 1, 2016

Implemented your feedback, makes more sense know. Let me know if something else needs to change!

@mgod
Copy link
Contributor

mgod commented Feb 1, 2016

Nice! Thanks for the changes.

mgod added a commit that referenced this pull request Feb 1, 2016
Fix for autocompleting with cursor in the middle
@mgod mgod merged commit ee4ccd1 into splitwise:master Feb 1, 2016
@dejarno
Copy link
Contributor Author

dejarno commented Feb 1, 2016

No problem! Any idea when this will be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants