fixed crash on long back press #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -461,7 +461,7 @@ protected void onSelectionChanged(int selStart, int selEnd) { | |||
| for (TokenImageSpan span: spans) { | |||
| int spanEnd = text.getSpanEnd(span); | |||
| if (selStart <= spanEnd && text.getSpanStart(span) < selStart) { | |||
| setSelection(spanEnd + 1); | |||
There was a problem hiding this comment.
You should add one to the span end in most cases (otherwise you can wind up with extra spaces in the text field after several deletes under some circumstances). So you should probably check to see if the spanEnd is equal to the length, and add one to it if it is not.
There was a problem hiding this comment.
Got you. You are right. Updated the source as per your comment and it works 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The below change fixes the crash on long press on backspace key.