Attempting to fix github pages kramdown rendering #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that the following variables must be defined: * SPLUNK_PASSWORD * SPLUNK_LICENSE_URI (requires a license that includes DFS) * SPLUNK_IMAGE (requires an image that includes this PR: splunk/splunk-ansible#194) Example: SPLUNK_PASSWORD=XXX SPLUNK_IMAGE=XXX SPLUNK_LICENSE_URI=XXX docker-compose -f 1sh1idx_dfs.yaml up -d
nwang92
requested review from
arctan5x,
bb03,
jmeixensperger,
jonathan-vega-splunk,
jrigassio-splunk and
lephino
arctan5x
previously approved these changes
Jul 31, 2019
Adding docker-compose test scenario for Splunk Enterprise with DFS.
openshift comply
jmeixensperger
approved these changes
Aug 19, 2019
lephino
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parsing down by github pages uses a different markdown engine than the standard. For instance, https://github.com/splunk/docker-splunk/blob/develop/docs/EXAMPLES.md renders beautifully but https://splunk.github.io/docker-splunk/EXAMPLES.html is pretty messed up.
This should also fix the issue brought up here: https://splunk.github.io/docker-splunk/EXAMPLES.html
I'm attempting to fix this - I haven't found a good way to validate these changes on my own local environment but I'm open to any suggestions while I continue some research on how to go about doing this.