Skip to content

Conversation

@alishamayor
Copy link
Contributor

Fixed formatting and broken navigation
Updated language for clarity and concision

For more instructions on how to bring your own certificates, please see: https://docs.splunk.com/Documentation/Splunk/latest/Security/ConfigureSplunkforwardingtousesignedcertificates
Fore further instructions, see [Configure Splunk forwarding to use your own certificates](https://docs.splunk.com/Documentation/Splunk/latest/Security/ConfigureSplunkforwardingtousesignedcertificates).

## Build from source
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should move this to CONTRIBUTING.md? I think we might want to tailor this ADVANCED.md section to outline/detail individual features of the Docker image and how it can be used by the end user.

Building images is more of a developer workflow, and the majority of end users should not need to know how to build everything from scratch (hopefully, assuming we've done our jobs in delivering a usable image :P)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs/refactor branch name is a bit of a misnomer here. I really only edited for content and clarity rather than the architecture of the docs, which is the next step. A bunch of sections definitely need to be shuffled around.

Copy link
Contributor Author

@alishamayor alishamayor Apr 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it needs to be separated out based on users and use cases, and I'll tackle that on the next go around. 🔨

@alishamayor alishamayor requested a review from nwang92 April 2, 2020 22:11
@alishamayor alishamayor merged commit b621fbe into develop Apr 3, 2020
@alishamayor alishamayor deleted the docs/refactor branch April 3, 2020 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants