Skip to content

Add logging #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 28, 2019
Merged

Add logging #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d41b67a
add logging to custom search commands app examples
Mar 14, 2019
59402a0
addressed comments
Mar 14, 2019
10cccfd
addressed comments
Mar 14, 2019
f463a04
address comments
Mar 14, 2019
d124304
fix test
Mar 27, 2019
801e960
fix unit test
Mar 27, 2019
30545b0
change handlers for sum command
Mar 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/searchcommands_app/package/bin/generatehello.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ class GenerateHelloCommand(GeneratingCommand):
count = Option(require=True, validate=validators.Integer(0))

def generate(self):
self.logger.debug("Generating %s events" % self.count)
for i in range(1, self.count + 1):
text = 'Hello World %d' % i
yield {'_time': time.time(), 'event_no': i, '_raw': text}
Expand Down
1 change: 1 addition & 0 deletions examples/searchcommands_app/package/bin/generatetext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ class GenerateTextCommand(GeneratingCommand):

def generate(self):
text = self.text
self.logger.debug("Generating %d events with text %s" % (self.count, self.text))
for i in range(1, self.count + 1):
yield {'_serial': i, '_time': time.time(), '_raw': six.text_type(i) + '. ' + text}

Expand Down
10 changes: 5 additions & 5 deletions examples/searchcommands_app/package/default/logging.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,15 @@ propagate = 0 ; Default: 1

[logger_GenerateHelloCommand]
qualname = GenerateHelloCommand
level = NOTSET ; Default: WARNING
level = DEBUG ; Default: WARNING
handlers = app ; Default: stderr
propagate = 0 ; Default: 1

[logger_GenerateTextCommand]
qualname = GenerateTextCommand
level = NOTSET ; Default: WARNING
handlers = app ; Default: stderr
propagate = 0 ; Default: 1
level = DEBUG ; Default: WARNING
handlers = app ; Default: stderr
propagate = 0 ; Default: 1
Copy link
Contributor

@shakeelmohamed shakeelmohamed Mar 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also update the logger_GenerateHelloCommand stanza

Copy link
Author

@xuchen509 xuchen509 Mar 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


[logger_SimulateCommand]
qualname = SimulateCommand
Expand All @@ -43,7 +43,7 @@ propagate = 0 ; Default: 1
[logger_SumCommand]
qualname = SumCommand
level = NOTSET ; Default: WARNING
handlers = app ; Default: stderr
handlers = splunklib ; Default: stderr
propagate = 0 ; Default: 1

[handlers]
Expand Down