New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IncludeExcludeExtensionSpec: improve Javadoc, remove static block #26

Merged
merged 1 commit into from Sep 24, 2018

Conversation

Projects
None yet
2 participants
@kriegaex
Contributor

kriegaex commented Sep 24, 2018

Setting system property "spock.configuration" during class
initialisation is too late for Spock to pick up the config, so the
static block is pointless and misleads users to believe they can
actually configure the system this way.

Instead the Javadoc was amended by information how to set the system
property via '-D' JVM command-line argument when running a test from an
IDE (or from the command line, for that matter).

Closes #25 .

Alexander Kriegisch Alexander Kriegisch
IncludeExcludeExtensionSpec: improve Javadoc, remove static block
Setting system property "spock.configuration" during class
initialisation is too late for Spock to pick up the config, so the
static block is pointless and misleads users to believe they can
actually configure the system this way.

Instead the Javadoc was amended by information how to set the system
property via '-D' JVM command-line argument when running a test from an
IDE (or from the command line, for that matter).

@leonard84 leonard84 merged commit 043ef13 into spockframework:master Sep 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@leonard84

This comment has been minimized.

Member

leonard84 commented Sep 24, 2018

thanks @kriegaex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment