-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spock does not work in tr_TR locale: Unrecognized block label: given @ line 31, column 13. #1414
Labels
Comments
This was referenced Jan 15, 2022
vlsi
added a commit
to vlsi/selenide
that referenced
this issue
Jan 16, 2022
This enables significantly improve test coverage while still keeping test feedback fast and easy configuration. For example, this matrix captures locale-dependent issues like spockframework/spock#1414 The idea is that you declare test axis like `os`, `java`, `java_distribution`, `timezone`, `locale`, etc, and `matrix.js` produces several jobs for you. See https://github.com/vlsi/github-actions-random-matrix Signed-off-by: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
vlsi
added a commit
to vlsi/selenide
that referenced
this issue
Jan 16, 2022
This enables significantly improve test coverage while still keeping test feedback fast and easy configuration. For example, this matrix captures locale-dependent issues like spockframework/spock#1414 The idea is that you declare test axis like `os`, `java`, `java_distribution`, `timezone`, `locale`, etc, and `matrix.js` produces several jobs for you. See https://github.com/vlsi/github-actions-random-matrix Signed-off-by: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
vlsi
added a commit
to vlsi/selenide
that referenced
this issue
Jan 16, 2022
This enables significantly improve test coverage while still keeping test feedback fast and easy configuration. For example, this matrix captures locale-dependent issues like spockframework/spock#1414 The idea is that you declare test axis like `os`, `java`, `java_distribution`, `timezone`, `locale`, etc, and `matrix.js` produces several jobs for you. See https://github.com/vlsi/github-actions-random-matrix Signed-off-by: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
vlsi
added a commit
to vlsi/selenide
that referenced
this issue
Jan 16, 2022
This enables significantly improve test coverage while still keeping test feedback fast and easy configuration. For example, this matrix captures locale-dependent issues like spockframework/spock#1414 The idea is that you declare test axis like `os`, `java`, `java_distribution`, `timezone`, `locale`, etc, and `matrix.js` produces several jobs for you. See https://github.com/vlsi/github-actions-random-matrix Signed-off-by: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
leonard84
added a commit
to leonard84/spock
that referenced
this issue
Jan 21, 2022
Prior to this commit, there were several instances of toLowerCase()/toUpperCase() using the default locale, this causes issues in certain locales like tr_TR. To fis this, we declare Locale.ROOT should be used in those cases. fixes spockframework#1414
leonard84
added a commit
that referenced
this issue
Feb 16, 2022
Prior to this commit, there were several instances of toLowerCase()/toUpperCase() using the default locale, this causes issues in certain locales like tr_TR. To fix this, we declare Locale.ROOT should be used in those cases. fixes #1414
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Spock fails with
tr_TR
locale:It blocks JMeter testing :-/
apache/jmeter#693
Reason:
Spock uses
.toLowerCase()
forBlockParseInfo
:spock/spock-core/src/main/java/org/spockframework/compiler/model/BlockParseInfo.java
Lines 139 to 141 in 3ebb5d3
The lookup fails here:
spock/spock-core/src/main/java/org/spockframework/compiler/SpecParser.java
Lines 212 to 225 in 3ebb5d3
Sample code in question (I believe it does not matter):
To Reproduce
run any Spock test with
-Duser.country=TR -Duser.language=tr
Expected behavior
tr_TR should be supported
Actual behavior
Unrecognized block label: given @ line 31, column 13
Java version
8, 11, 17
Buildtool version
Gradle 7.3
What operating system are you using
Windows
Dependencies
I believe it is irrelevant
Additional context
No response
The text was updated successfully, but these errors were encountered: