New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MethodInvocation interceptors sortable #757

Closed
tkvw opened this Issue Aug 17, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@tkvw

tkvw commented Aug 17, 2017

There is no way to sort the interceptors of a methodinvocation;

interceptors = method.getInterceptors().iterator();

I would be nice to allow sorting (check if the interceptor implements Comparable) of the interceptors in some way. I want to make an extension but it depends on another extension to have run setupSpec before, or is this intentional behaviour? I can make a PR for this.

@leonard84

This comment has been minimized.

Show comment
Hide comment
@leonard84

leonard84 Aug 20, 2017

Member

@tkvw extensions should work independently. Could you describe your use case a bit more in detail.

Member

leonard84 commented Aug 20, 2017

@tkvw extensions should work independently. Could you describe your use case a bit more in detail.

@tkvw

This comment has been minimized.

Show comment
Hide comment
@tkvw

tkvw Aug 24, 2017

I develop using grails, it uses interceptors to setup some tests. One of the interceptors sets up a mock persistent enviroment. I want to make an interceptor which depends on the fact that the persistent environment is setup before it can run it's setupSpec.

tkvw commented Aug 24, 2017

I develop using grails, it uses interceptors to setup some tests. One of the interceptors sets up a mock persistent enviroment. I want to make an interceptor which depends on the fact that the persistent environment is setup before it can run it's setupSpec.

@leonard84

This comment has been minimized.

Show comment
Hide comment
@leonard84

leonard84 Sep 21, 2017

Member

Relates #646

Member

leonard84 commented Sep 21, 2017

Relates #646

@tkvw

This comment has been minimized.

Show comment
Hide comment
@tkvw

tkvw Jan 13, 2018

I'll close this in favor of #646

tkvw commented Jan 13, 2018

I'll close this in favor of #646

@tkvw tkvw closed this Jan 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment