New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unmatched invocations rendering #901

Open
leonard84 opened this Issue Sep 10, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@leonard84
Member

leonard84 commented Sep 10, 2018

The current rendering of unmatched invocations does not provide any hints on why it didn't match.

Too few invocations for:

1 * registrationService.register(_ as StaticClientContext, TEST_EMAIL, VALID_PASSWORD, CORRELATION_ID, CONSENT_TEXT)   (0 invocations)

Unmatched invocations (ordered by similarity):

1 * registrationService.register(StaticClientContext(forwardedFor=127.0.0.1, tenant=test-tenant, origin=null, referer=http://localhost/registration), test@domain.de, '12345678', 10ec9e3e-3d96-461f-a099-38bf2ddbe6aa, 'I agree to the terms and conditions')

It would be helpful to get a power assert like mismatch description, or at least every condition that did not match.

Thinks to keep in mind:

  • This looks obvious with only one call, but it has to work with 100+ calls also
  • We probably only want to describe the mismatch for the top 1-3 unmateched invocations
  • Do we also want to describe the expectation?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment