Fix equality checking of Comparable Mocks#1323
Merged
leonard84 merged 4 commits intospockframework:masterfrom Sep 29, 2022
Merged
Fix equality checking of Comparable Mocks#1323leonard84 merged 4 commits intospockframework:masterfrom
leonard84 merged 4 commits intospockframework:masterfrom
Conversation
`EqualArgumentConstraint` uses `DefaultTypeTransformation.compareEqual` to check arguments' equality in interactions. For most objects, this is equivalent to calling `.equals`, so Java Mocks come with an intuitive default implemention of `.equals`. But for objects that are `Comparable` (including Mocks of types that implement `Comparable`), `DefaultTypeTransformation.compareEqual(x, y)` is equivalent to calling `x.compareTo(y) == 0`. As a result, all Mocks of Comparable types are treated as equal by `EqualArgumentConstraint`. This commit fixes that by adding a default implementation of `.compareTo` to `Comparable` Mocks.
Codecov ReportBase: 79.84% // Head: 79.83% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1323 +/- ##
============================================
- Coverage 79.84% 79.83% -0.02%
- Complexity 4059 4065 +6
============================================
Files 414 415 +1
Lines 12848 12856 +8
Branches 1662 1665 +3
============================================
+ Hits 10259 10263 +4
- Misses 1988 1989 +1
- Partials 601 604 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
leonard84
previously approved these changes
Sep 29, 2022
leonard84
approved these changes
Sep 29, 2022
leonard84
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EqualArgumentConstraintusesDefaultTypeTransformation.compareEqualto check arguments' equality in interactions. For most objects, this is
equivalent to calling
.equals, so Java Mocks come with an intuitivedefault implemention of
.equals. But for objects that areComparable(including Mocks of types that implement
Comparable),DefaultTypeTransformation.compareEqual(x, y)is equivalent to callingx.compareTo(y) == 0. As a result, all Mocks of Comparable types aretreated as equal by
EqualArgumentConstraint.This commit fixes that by adding a default implementation of
.compareTotoComparableMocks.