Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception translation to JUnit4 Rules #1342

Conversation

leonard84
Copy link
Member

No description provided.

@leonard84 leonard84 enabled auto-merge (rebase) May 27, 2021 08:43
@leonard84 leonard84 requested a review from szpak June 1, 2021 12:51
@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #1342 (76e8419) into master (305a08f) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1342      +/-   ##
============================================
- Coverage     79.21%   79.21%   -0.01%     
- Complexity     3955     3956       +1     
============================================
  Files           408      408              
  Lines         12307    12314       +7     
  Branches       1627     1627              
============================================
+ Hits           9749     9754       +5     
- Misses         1975     1977       +2     
  Partials        583      583              
Impacted Files Coverage Δ
...spockframework/junit4/AbstractRuleInterceptor.java 80.95% <75.00%> (-4.77%) ⬇️
...rg/spockframework/junit4/ClassRuleInterceptor.java 90.90% <100.00%> (ø)
...org/spockframework/junit4/TestRuleInterceptor.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 305a08f...76e8419. Read the comment docs.

Copy link
Member

@marcphilipp marcphilipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@leonard84 leonard84 merged commit 77ff0c7 into spockframework:master Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants