Set the owner for condition closures on spec annotations#1357
Merged
leonard84 merged 3 commits intoJul 17, 2021
Conversation
This allows access to static methods when `@IgnoreIf`, `@Requires` and `@PendingFeatureIf` is used on a Specification. We already set the owner when a Feature is annotated.
Codecov Report
@@ Coverage Diff @@
## master #1357 +/- ##
============================================
+ Coverage 79.22% 79.23% +0.01%
+ Complexity 3944 3943 -1
============================================
Files 408 408
Lines 12263 12262 -1
Branches 1617 1617
============================================
+ Hits 9715 9716 +1
+ Misses 1967 1965 -2
Partials 581 581
Continue to review full report at Codecov.
|
marcphilipp
previously approved these changes
Jul 17, 2021
Co-authored-by: Marc Philipp <marc@gradle.com>
marcphilipp
approved these changes
Jul 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows access to static methods when
@IgnoreIf,@Requiresand@PendingFeatureIfis used on a Specification.We already set the owner when a Feature is annotated.