Skip to content

Conversation

@l0rinc
Copy link
Contributor

@l0rinc l0rinc commented Jul 21, 2021

Fixes #1361

@l0rinc l0rinc changed the title Aadd reason to requires and ignore if Add reason to requires and ignore if Jul 21, 2021
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #1362 (7897558) into master (450dc1b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1362      +/-   ##
============================================
+ Coverage     79.20%   79.21%   +0.01%     
- Complexity     3951     3955       +4     
============================================
  Files           408      408              
  Lines         12299    12309      +10     
  Branches       1624     1627       +3     
============================================
+ Hits           9741     9751      +10     
  Misses         1975     1975              
  Partials        583      583              
Impacted Files Coverage Δ
...k/runtime/extension/builtin/IgnoreIfExtension.java 100.00% <100.00%> (ø)
...k/runtime/extension/builtin/RequiresExtension.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 450dc1b...7897558. Read the comment docs.

@leonard84 leonard84 changed the title Add reason to requires and ignore if Add optional reason to Requires and IgnoreIf Jul 21, 2021
@leonard84 leonard84 merged commit f183e7b into spockframework:master Jul 21, 2021
@leonard84
Copy link
Member

thanks @paplorinc

@kriegaex
Copy link
Contributor

I know this was merged already, I just found it in the 2.1-M1 release notes. It seems that the reason parameter is undocumented in the Spock manual. Was that on purpose or does it deserve its own little issue?

@leonard84
Copy link
Member

It is not directly on purpose. If you want to create a PR with some documentation you are welcome to do it.

Personally, I think it is discoverable enough, when I write code with an IDE I normally use auto complete, or show parameters to see what fields I have available.

@l0rinc l0rinc deleted the lorinc/add-reason-to-requires-and-ignore-if branch February 11, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add reason to Requires & co.

3 participants