Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bnd: Update for 6.0.0 release #1377

Merged
merged 1 commit into from Oct 6, 2021
Merged

Conversation

bjhargrave
Copy link
Contributor

We use the new bundle extension for bnd configuration. We also update
the verifyOSGi task to use the new output property to enable
up-to-date builds.

We use the new bundle extension for bnd configuration. We also update
the verifyOSGi task to use the new output property to enable
up-to-date builds.

Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Copy link
Contributor

@rotty3000 rotty3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szpak
Copy link
Member

szpak commented Oct 5, 2021

@rotty3000 I just wanted to ask you about your opinion on that topic. Thanks for your precognition skills ;-).

@bjhargrave
Copy link
Contributor Author

@rotty3000 Made me make this PR :-)

@szpak
Copy link
Member

szpak commented Oct 5, 2021

@rotty3000 Made me make this PR :-)

And everything is clear now :-). I'm glad he organized an another person to help with OSGI in Spock 👍

@rotty3000
Copy link
Contributor

@szpak for future reference, @bjhargrave is the go to w.r.t. OSGi (and pretty much any other programming doubts 😓) you shouldn't need my blessing if he sends a PR cause he's likely improved on anything I would have submitted 😁

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #1377 (d9bafab) into master (6cf09c6) will increase coverage by 0.04%.
The diff coverage is 93.18%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1377      +/-   ##
============================================
+ Coverage     79.26%   79.31%   +0.04%     
- Complexity     3950     3966      +16     
============================================
  Files           402      403       +1     
  Lines         12290    12298       +8     
  Branches       1625     1619       -6     
============================================
+ Hits           9742     9754      +12     
+ Misses         1965     1960       -5     
- Partials        583      584       +1     
Impacted Files Coverage Δ
.../spockframework/runtime/model/IterationFilter.java 91.66% <91.66%> (ø)
...spockframework/runtime/MethodSelectorResolver.java 90.69% <92.85%> (+12.12%) ⬆️
...ework/runtime/PlatformParameterizedSpecRunner.java 77.94% <100.00%> (+0.16%) ⬆️
.../org/spockframework/runtime/model/FeatureInfo.java 98.27% <100.00%> (+0.06%) ⬆️
.../spockframework/builder/CollectionSlotFactory.java 87.50% <0.00%> (-1.39%) ⬇️
...pockframework/mock/runtime/InteractionBuilder.java 86.95% <0.00%> (-0.55%) ⬇️
.../java/org/spockframework/runtime/SpockRuntime.java 70.78% <0.00%> (-0.33%) ⬇️
...n/java/org/spockframework/util/ReflectionUtil.java 80.35% <0.00%> (-0.18%) ⬇️
...spockframework/runtime/ExpressionInfoRenderer.java 92.72% <0.00%> (-0.13%) ⬇️
...k/runtime/FailedSetEqualityComparisonRenderer.java 96.42% <0.00%> (-0.13%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0e5f62...d9bafab. Read the comment docs.

@szpak szpak merged commit fa8a2cc into spockframework:master Oct 6, 2021
@bjhargrave bjhargrave deleted the bnd-6.0.0 branch October 6, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants