Discard unnecessary state in ConfineMetaClassChangesInterceptor#1460
Merged
leonard84 merged 2 commits intospockframework:masterfrom May 4, 2022
mattmoss:master
Merged
Discard unnecessary state in ConfineMetaClassChangesInterceptor#1460leonard84 merged 2 commits intospockframework:masterfrom mattmoss:master
leonard84 merged 2 commits intospockframework:masterfrom
mattmoss:master
Conversation
Member
|
Looking at the original code, |
Contributor
Author
Agreed, good catch. Will revise. |
added 2 commits
May 4, 2022 11:38
If @ConfineMetaClassChanges is used on a data-driver feature method, the ConfineMetaClassChangesInterceptor is shared between iterations of the method. Clear the originalMetaClasses field of the interceptor after each invocation to avoid populating the list with duplicate references to original meta-classes. The previous implementation was not defective, per se, but this fixes a potential efficiency issue (determined by how many meta-classes are stored and how many iterations of the feature method are run).
Codecov Report
@@ Coverage Diff @@
## master #1460 +/- ##
=========================================
Coverage 79.59% 79.59%
Complexity 4010 4010
=========================================
Files 404 404
Lines 12563 12563
Branches 1641 1641
=========================================
Hits 9999 9999
Misses 1969 1969
Partials 595 595
Continue to review full report at Codecov.
|
leonard84
approved these changes
May 4, 2022
leonard84
changed the title
Member
|
thanks @mattmoss |
leonard84
added a commit
to kriegaex/spock
that referenced
this pull request
May 21, 2022
* master: Bump org.gradle.test-retry from 1.3.2 to 1.4.0 Make EnableSharedInjection public (spockframework#1472) Remove runtime dependency on Jetbrains Annotations (spockframework#1468) Add Dependabot configuration Use static imports for well known methods of Collections and Arrays Refactor SpecInfo extract shared logic into collectSpecHierarchy Discard unnecessary state in ConfineMetaClassChangesInterceptor (spockframework#1460) Update Groovy to 4.0.2 Update Gradle plugins Update Gradle to 7.4.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
@ConfineMetaClassChangesis used on a data-driver feature method, theConfineMetaClassChangesInterceptoris shared between iterations of themethod. Clear the
originalMetaClassesfield of the interceptor aftereach invocation to avoid populating the list with duplicate references
to original meta-classes.
The previous implementation was not defective per se, but this fixes a
potential efficiency issue (determined by how many meta-classes are
stored and how many iterations of the feature method are run).