Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for named deconstruction of Multi-Variable Data Pipes #1463

Merged
merged 4 commits into from
Jul 7, 2022

Conversation

leonard84
Copy link
Member

No description provided.

@leonard84 leonard84 changed the title Add status quo AST test Add support for named deconstruction of Multi-Variable Data Pipes Apr 27, 2022
@leonard84 leonard84 self-assigned this Apr 27, 2022
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #1463 (c94aec3) into master (3f9817c) will increase coverage by 79.73%.
The diff coverage is 83.33%.

@@              Coverage Diff              @@
##             master    #1463       +/-   ##
=============================================
+ Coverage          0   79.73%   +79.73%     
- Complexity        0     4023     +4023     
=============================================
  Files             0      411      +411     
  Lines             0    12715    +12715     
  Branches          0     1649     +1649     
=============================================
+ Hits              0    10138    +10138     
- Misses            0     1982     +1982     
- Partials          0      595      +595     
Impacted Files Coverage Δ
...main/java/org/spockframework/compiler/AstUtil.java 80.27% <80.00%> (ø)
...rg/spockframework/compiler/WhereBlockRewriter.java 94.01% <100.00%> (ø)
...it4/JUnit4AnnotationLifecycleMethodsExtension.java 92.68% <0.00%> (ø)
...rg/spockframework/mock/runtime/MockController.java 100.00% <0.00%> (ø)
...rk/runtime/extension/builtin/TempDirExtension.java 85.71% <0.00%> (ø)
...kframework/spring/mock/SpockMockPostprocessor.java 85.03% <0.00%> (ø)
...ckframework/report/log/ReportLogConfiguration.java 100.00% <0.00%> (ø)
...ime/extension/builtin/PendingFeatureExtension.java 100.00% <0.00%> (ø)
...org/spockframework/unitils/UnitilsInterceptor.java 87.50% <0.00%> (ø)
...work/runtime/extension/builtin/TitleExtension.java 100.00% <0.00%> (ø)
... and 403 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f9817c...c94aec3. Read the comment docs.

marcphilipp
marcphilipp previously approved these changes Jul 5, 2022
Copy link
Member

@marcphilipp marcphilipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a user's perspective! I can't really speak to the AST transform, though.

@leonard84 leonard84 enabled auto-merge (squash) July 7, 2022 16:33
@leonard84 leonard84 disabled auto-merge July 7, 2022 16:48
@leonard84 leonard84 merged commit 05a8e0d into spockframework:master Jul 7, 2022
@leonard84 leonard84 deleted the mv-pipes-map-access branch July 7, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants