Add junit-platform TestTag support#1467
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1467 +/- ##
============================================
+ Coverage 79.61% 79.66% +0.05%
- Complexity 4015 4040 +25
============================================
Files 404 407 +3
Lines 12565 12611 +46
Branches 1640 1642 +2
============================================
+ Hits 10003 10047 +44
- Misses 1967 1968 +1
- Partials 595 596 +1
Continue to review full report at Codecov.
|
marcphilipp
approved these changes
May 21, 2022
| return value != null && value.length() > 0 && value.codePoints().noneMatch(INVALID_CODE_POINTS); | ||
| } | ||
|
|
||
| private static String getInvalidCharacters(@Nullable String value) { |
Member
There was a problem hiding this comment.
I think we should move this to the JUnit Platform so this TestTag can be a simple wrapper around JUnit Platform's TestTag.
|
@marcphilipp @leonard84 good to see this feature, when we can expect it to be released? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supersedes #1437