Repository navigation
Conversation
szpak
approved these changes
May 16, 2022
Member
|
Thanks @jonnybot0 . |
leonard84
added a commit
to kriegaex/spock
that referenced
this pull request
May 21, 2022
* master: Bump org.gradle.test-retry from 1.3.2 to 1.4.0 Make EnableSharedInjection public (spockframework#1472) Remove runtime dependency on Jetbrains Annotations (spockframework#1468) Add Dependabot configuration Use static imports for well known methods of Collections and Arrays Refactor SpecInfo extract shared logic into collectSpecHierarchy Discard unnecessary state in ConfineMetaClassChangesInterceptor (spockframework#1460) Update Groovy to 4.0.2 Update Gradle plugins Update Gradle to 7.4.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick fix for #1471
Based on the release notes from 2.0.0-M5, it looks like the
EnableSharedInjectionannotation should be public.While the annotation appears to work as expected despite being package-private, it does produce some noisy IDE warnings that are worth getting rid of.
This doesn't seem to affect the tests in
org.spockframework.spring.SharedFieldsInjection. I don't think it merits a test of its own, but I could be wrong.