Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make EnableSharedInjection public #1472

Conversation

jonnybot0
Copy link
Contributor

Quick fix for #1471

Based on the release notes from 2.0.0-M5, it looks like the EnableSharedInjection annotation should be public.

While the annotation appears to work as expected despite being package-private, it does produce some noisy IDE warnings that are worth getting rid of.

This doesn't seem to affect the tests in org.spockframework.spring.SharedFieldsInjection. I don't think it merits a test of its own, but I could be wrong.

@szpak szpak merged commit 4eb2e10 into spockframework:master May 16, 2022
@szpak
Copy link
Member

szpak commented May 16, 2022

Thanks @jonnybot0 .

@szpak szpak added this to the 2.2 milestone May 16, 2022
leonard84 added a commit to kriegaex/spock that referenced this pull request May 21, 2022
* master:
  Bump org.gradle.test-retry from 1.3.2 to 1.4.0
  Make EnableSharedInjection public (spockframework#1472)
  Remove runtime dependency on Jetbrains Annotations (spockframework#1468)
  Add Dependabot configuration
  Use static imports for well known methods of Collections and Arrays
  Refactor SpecInfo extract shared logic into collectSpecHierarchy
  Discard unnecessary state in ConfineMetaClassChangesInterceptor (spockframework#1460)
  Update Groovy to 4.0.2
  Update Gradle plugins
  Update Gradle to 7.4.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants