Introduce DataIterator and IDataDriver#1479
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1479 +/- ##
=============================================
+ Coverage 0 79.73% +79.73%
- Complexity 0 4024 +4024
=============================================
Files 0 411 +411
Lines 0 12710 +12710
Branches 0 1649 +1649
=============================================
+ Hits 0 10134 +10134
- Misses 0 1981 +1981
- Partials 0 595 +595
Continue to review full report at Codecov.
|
wolfs
previously approved these changes
Jun 2, 2022
wolfs
left a comment
There was a problem hiding this comment.
I used this to replace an ugly hack for Gradle's multi version extension, and it works good! So I'd like to have this as a feature and would use it.
marcphilipp
reviewed
Jun 3, 2022
…custom data driver
marcphilipp
previously approved these changes
Jun 19, 2022
marcphilipp
approved these changes
Jun 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main motivation is to extract the
DataIteratorlogic from thePlatformParameterizedSpecRunnerinto a reusable form, so that it canserve as foundation for data driven specs in the future.
This also opened up the possibility of adding a new extension point
IDataDriver,which can be used to control the actual iterations of a feature.
A possible use-case is to enable property based testing like jqwik
via a third-party extension.