-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce DataIterator and IDataDriver #1479
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1479 +/- ##
=============================================
+ Coverage 0 79.73% +79.73%
- Complexity 0 4024 +4024
=============================================
Files 0 411 +411
Lines 0 12710 +12710
Branches 0 1649 +1649
=============================================
+ Hits 0 10134 +10134
- Misses 0 1981 +1981
- Partials 0 595 +595
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used this to replace an ugly hack for Gradle's multi version extension, and it works good! So I'd like to have this as a feature and would use it.
spock-specs/src/test/groovy/org/spockframework/runtime/EstimatedNumberOfIterations.groovy
Outdated
Show resolved
Hide resolved
spock-core/src/main/java/org/spockframework/runtime/extension/IDataDriver.java
Outdated
Show resolved
Hide resolved
…custom data driver
The main motivation is to extract the
DataIterator
logic from thePlatformParameterizedSpecRunner
into a reusable form, so that it canserve as foundation for data driven specs in the future.
This also opened up the possibility of adding a new extension point
IDataDriver
,which can be used to control the actual iterations of a feature.
A possible use-case is to enable property based testing like jqwik
via a third-party extension.