Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate uniqueness of fixture methods per specification class #1521

Conversation

leonard84
Copy link
Member

fixes #1512

@leonard84 leonard84 self-assigned this Sep 6, 2022
@leonard84 leonard84 added this to the 2.3 milestone Sep 6, 2022
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #1521 (4c8cc00) into master (044e529) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1521   +/-   ##
=========================================
  Coverage     79.80%   79.80%           
+ Complexity     4052     4050    -2     
=========================================
  Files           412      412           
  Lines         12795    12798    +3     
  Branches       1655     1656    +1     
=========================================
+ Hits          10211    10214    +3     
  Misses         1985     1985           
  Partials        599      599           
Impacted Files Coverage Δ
...va/org/spockframework/runtime/SpecInfoBuilder.java 99.22% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

szpak
szpak previously approved these changes Sep 6, 2022
docs/spock_primer.adoc Outdated Show resolved Hide resolved
piotrminkina
piotrminkina previously approved these changes Sep 7, 2022
Copy link

@piotrminkina piotrminkina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you very much :)

@leonard84 leonard84 dismissed stale reviews from piotrminkina and szpak via 4c8cc00 September 11, 2022 20:20
@leonard84 leonard84 force-pushed the validate_unique_fixture_methods_per_class branch from bf8c21e to 4c8cc00 Compare September 11, 2022 20:20
@leonard84 leonard84 merged commit 61eefe5 into spockframework:master Sep 12, 2022
@leonard84 leonard84 deleted the validate_unique_fixture_methods_per_class branch September 12, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Count of invocation arguments varies for fixture methods that use default values
3 participants