Skip to content

Make RetryExtension more parallel-safe (#1700) - #1701

Merged
leonard84 merged 3 commits into
masterfrom
issue-1700
Mar 4, 2024
Merged

leonard84 merged 3 commits into
masterfrom
issue-1700

Conversation

@Vampire

@Vampire Vampire commented Jun 19, 2023

Copy link
Copy Markdown
Member

Fixes #1700

@Vampire

Vampire commented Jun 19, 2023 •

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Vampire and the rest of your teammates on Graphite Graphite

@codecov

codecov Bot commented Jun 19, 2023 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 94.73684% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.31%. Comparing base (2c7db77) to head (a2d357d).
Report is 40 commits behind head on master.

❗ Current head a2d357d differs from pull request most recent head 2f6e3db. Consider uploading reports for the commit 2f6e3db to get more accurate results

Files Patch % Lines
...e/extension/builtin/RetryIterationInterceptor.java 94.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1701      +/-   ##
============================================
- Coverage     80.44%   80.31%   -0.14%     
+ Complexity     4337     4305      -32     
============================================
  Files           441      439       -2     
  Lines         13534    13480      -54     
  Branches       1707     1701       -6     
============================================
- Hits          10888    10827      -61     
- Misses         2008     2009       +1     
- Partials        638      644       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Vampire
Vampire force-pushed the issue-1700 branch 4 times, most recently from b213014 to 7e3fd03 Compare August 21, 2023 19:03
@Vampire
Vampire requested a review from leonard84 August 21, 2023 19:29
@Vampire
Vampire requested a review from AndreasTu August 25, 2023 02:28
AndreasTu
AndreasTu previously approved these changes Aug 25, 2023
@Vampire
Vampire force-pushed the issue-1700 branch 2 times, most recently from 578bafd to 51726c4 Compare September 16, 2023 10:35
@Vampire
Vampire force-pushed the issue-1700 branch 2 times, most recently from 9ca55a6 to 56388b8 Compare September 18, 2023 23:40
@Vampire
Vampire force-pushed the issue-1700 branch 3 times, most recently from e841dba to b6c5f17 Compare October 14, 2023 11:35
@Vampire
Vampire force-pushed the issue-1700 branch 3 times, most recently from cd055a8 to 27192ff Compare November 7, 2023 00:01
@Vampire
Vampire force-pushed the issue-1700 branch 4 times, most recently from 97a5ae7 to 761850a Compare November 13, 2023 00:50
@Vampire
Vampire force-pushed the issue-1700 branch 2 times, most recently from 35d5088 to 4284b0e Compare November 27, 2023 23:43
@Vampire
Vampire force-pushed the issue-1700 branch 3 times, most recently from f12ea09 to b96882a Compare December 1, 2023 01:20
@Vampire
Vampire force-pushed the issue-1700 branch 2 times, most recently from 8bd5017 to a2d357d Compare December 18, 2023 12:49
@leonard84
leonard84 enabled auto-merge (squash) March 4, 2024 21:11
@leonard84
leonard84 merged commit 60d6bfb into master Mar 4, 2024
@leonard84
leonard84 deleted the issue-1700 branch March 4, 2024 21:15
@Vampire Vampire added this to the 2.4-M3 milestone Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@Retry with mode SETUP_FEATURE_CLEANUP is not fully parallel-safe (swallowing failures or throwing NullPointerException)

3 participants