MockFactory via ServiceLoader

[AndreasTu]

Added API IMockMaker to make the mock creation pluggable via the ServiceLoader pattern.
The MockMakerRegistry provides access to the different IMockMaker.

This fixes #1220

[codecov]

Codecov Report

Patch coverage: 96.26% and project coverage change: +0.46% 🎉

Comparison is base (b749611) 79.87% compared to head (2423c59) 80.34%.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1746      +/-   ##
============================================
+ Coverage     79.87%   80.34%   +0.46%     
- Complexity     4100     4192      +92     
============================================
  Files           425      431       +6     
  Lines         12969    13157     +188     
  Branches       1644     1670      +26     
============================================
+ Hits          10359    10571     +212     
+ Misses         1998     1972      -26     
- Partials        612      614       +2     

Files Changed	Coverage Δ
...pock-core/src/main/java/spock/mock/MockingApi.java	2.88% <ø> (ø)
...pockframework/mock/runtime/ByteBuddyMockMaker.java	80.00% <80.00%> (ø)
...va/org/spockframework/mock/runtime/IMockMaker.java	92.50% <92.50%> (ø)
...ckframework/mock/runtime/MockCreationSettings.java	95.45% <95.45%> (ø)
...spockframework/mock/runtime/MockMakerRegistry.java	97.84% <97.84%> (ø)
...rc/main/java/org/spockframework/mock/MockUtil.java	100.00% <100.00%> (ø)
...ckframework/mock/runtime/ByteBuddyMockFactory.java	91.78% <100.00%> (+0.23%)	⬆️
.../spockframework/mock/runtime/CglibMockFactory.java	60.00% <100.00%> (+60.00%)	⬆️
...rg/spockframework/mock/runtime/CglibMockMaker.java	100.00% <100.00%> (ø)
...spockframework/mock/runtime/GroovyMockFactory.java	72.97% <100.00%> (-0.72%)	⬇️
... and 9 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AndreasTu]

I chose the name IMockMaker similar as in Mockito, because the I found the word Factory clases with the existing JavaMockFactory/GroovyMockFactory.

Missing stuff & discussions:

• name of the property mockMaker: in Mock()/Stub()/Spy() API
• Configuration of the MockMaker
• The hard coded priorities for the internal IMockMaker
• Documentation
• Proof of concept, if the new API could now integrate the Mockito inline-mock-maker

[leonard84]

This looks promising. Here are my first comments. I haven't yet thought about every aspect.

@spockframework/supporter any comments on the usability side?

[AndreasTu]

The PR #1753 contains the code to implement final class/final method mocking with Mockito.
The Pr implements an IMockMaker using Mockito API.

[AndreasTu]

The PR #1756 contains the code to support static method mocking with the mockito-inline-mock-maker introduced in #1753.

[AndreasTu]

@leonard84 I have changed the access to the MockMakerRegistry to RunContext.get().getMockMakerRegistry().
And I have changed the configuration of the preferredMockMaker to a ConfigurationObject named MockMakerRegistryConfiguration.

Usage sample:

//spock-configuration-file
mockMaker {
  preferredMockMaker = "your-preferred-mock-maker"
}

[Vampire]

Looks good to me in general.
Just some detail points, and a lot of improvement suggestions. :-)

[Vampire]

Looks already very good imho.
Just some more details. :-)

[Vampire]

Mea culpa, tests were broken due to bad review, I fixed them

[AndreasTu]

@Vampire I hope I have nothing forgotten.
GitHub gets a bit tricky and sluggish, with so much stuff going on in a PR.

[Vampire]

I hope I have nothing forgotten.

I think from my side areis currently only twoone points left.
The two conversations I re-opened.
#1746 (comment) where @leonard84 should reply
and #1746 (comment).

[leonard84]

@AndreasTu all looks good now, I tried to rebase it so that I can directly merge it, but the resulting merge and changes were non-trivial. If you be so kind to resolve them, either by rebase or merge (they will be squash merged in the end).

Also it would be nice, if you could write an entry for the release notes.

[AndreasTu]

@leonard84 I have rebased the PR.

[leonard84]

@AndreasTu thanks for all the work