Repository navigation
Conversation
added 5 commits
October 18, 2023 15:06
…ameter of the closure
questras
marked this pull request as draft
December 20, 2023 14:28
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1853 +/- ##
=============================================
+ Coverage 0 79.70% +79.70%
- Complexity 0 4275 +4275
=============================================
Files 0 434 +434
Lines 0 13323 +13323
Branches 0 1695 +1695
=============================================
+ Hits 0 10619 +10619
- Misses 0 2065 +2065
- Partials 0 639 +639 ☔ View full report in Codecov by Sentry. |
added 2 commits
December 29, 2023 14:10
questras
marked this pull request as ready for review
December 29, 2023 13:54
leonard84
requested changes
Dec 29, 2023
leonard84
left a comment
leonard84
left a comment
Member
There was a problem hiding this comment.
Looks good, just a few small things
Co-authored-by: Leonard Brünings <lord_damokles@gmx.net>
Co-authored-by: Leonard Brünings <lord_damokles@gmx.net>
Co-authored-by: Leonard Brünings <lord_damokles@gmx.net>
leonard84
approved these changes
Jan 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1355
The method definition is different than suggested by the author of the issue but I believe it is true to the description of the feature