New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Spring-Boot 1.4 @SpringBootTest annotation #582

Merged
merged 2 commits into from May 23, 2016

Conversation

Projects
None yet
4 participants
@kiview

kiview commented Apr 30, 2016

See #581 for the issue.

Spring-Boot 1.4 will introduce a new annotation for test classes called @SpringBootTest to avoid some of the integration test boilerplate annotations.

Currently the spock-spring plugin does not recognize this annotation in order to identify this class as a Spring test class and instead relies on other annotations like @ContextHierarchy or @ContextConfiguration which do not need to be present if @SpringBootTest used.

I've introduced a check for the @SpringBootTest in the SpringExtension class similar to the other checks.

I've also added a new test for this annotation and cleaned up the boot-test.gradle file to include only the needed dependencies.

@kiview kiview changed the title from Added support for Spring-Boot 1.4 @SpringBootTest annotation #581 to Added support for Spring-Boot 1.4 @SpringBootTest annotation Apr 30, 2016

@szpak

This comment has been minimized.

Show comment
Hide comment
@szpak

szpak Apr 30, 2016

Contributor

LGTM

Contributor

szpak commented Apr 30, 2016

LGTM

@robfletcher robfletcher merged commit 5219948 into spockframework:master May 23, 2016

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@robfletcher robfletcher modified the milestone: 1.1-rc-1 Aug 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment