Add documentation for the spring module

[leonard84]

No description provided.

[robfletcher]

Is it worth documenting that you can also do this?

@Bean public FactoryBean<GreeterService> serviceMock() {
  return new SpockMockFactoryBean(GreeterService.class);
}

[kiview]

So this example will add a GreeterService Bean to the Spring context?

Since I did not knew this before, I'd love to see this solution mentioned in the docs as well.

[robfletcher]

Yes it would. I guess it's just a different pattern that doesn't require the DetachedMockFactory instance. It does exactly the same thing.

[robfletcher]

Looks good. I think this is a really useful addition to 1.1 as this was super-painful before.

[snekse]

When testing against a real app, I got caught in a turtles all the way down scenario.

I was testing a controller that depended on a service that depended on a repo. The test would fail because the repo wasn’t mocked. Turns out it was mostly caused by us using @autowired on the field instead of the constructor.

It’s worth noting in the docs. I’ve updated my example with some notes.

snekse/spock-webmvctest@2d86454

[leonard84]

@snekse I don't know. It is not actually the fault of the DetachedMockFactory it is just the way spring behaves. I personally always use Interfaces for services and such, avoiding class-Mocking has its benefits.

[kiview]

@snekse As a rule of thumb, you should simply avoid field injection. And using constructor injection has become even easier in Spring-Boot 1.4, since @Autowired is automatically applied to a constructor without specifying it explicitly.

I don't think this behavior needs to be mentioned in the Spock docs.