Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @SpringBean mocks throwing UndeclaredThrowableException for ... #878

Merged

Conversation

leonard84
Copy link
Member

actual declared exceptions

szpak
szpak previously approved these changes Aug 17, 2018
Copy link
Member

@szpak szpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ServiceWithDeclaredException service = Mock()

@Autowired
Consumer consumer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong indentation.

@codecov
Copy link

codecov bot commented Aug 17, 2018

Codecov Report

Merging #878 into master will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #878      +/-   ##
============================================
- Coverage     74.98%   74.97%   -0.02%     
  Complexity     3412     3412              
============================================
  Files           368      368              
  Lines         10515    10518       +3     
  Branches       1320     1320              
============================================
+ Hits           7885     7886       +1     
- Misses         2166     2168       +2     
  Partials        464      464
Impacted Files Coverage Δ Complexity Δ
...ckframework/spring/mock/DelegatingInterceptor.java 52.5% <33.33%> (-1.56%) 6 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb09055...5640f94. Read the comment docs.

@leonard84 leonard84 merged commit 748c12b into spockframework:master Aug 17, 2018
@leonard84 leonard84 deleted the fix-UndeclaredThrowableException branch August 17, 2018 15:34
szpak added a commit to szpak/spock that referenced this pull request Aug 29, 2018
To do not get another issue similar to spockframework#887 before RC2 is released.
leonard84 pushed a commit that referenced this pull request Aug 30, 2018
To do not get another issue similar to #887 before RC2 is released.
MartyIX pushed a commit to MartyIX/spock that referenced this pull request Oct 14, 2018
To do not get another issue similar to spockframework#887 before RC2 is released.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants