Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude groovy-groovysh dependency #882

Merged
merged 1 commit into from
Sep 9, 2018

Conversation

szpak
Copy link
Member

@szpak szpak commented Aug 26, 2018

It is needed only to start the Groovy console and should not pollute the compile classpath with the number of transitive dependencies:

+--- org.spockframework:spock-core:1.2-RC1-groovy-2.5
|    +--- org.codehaus.groovy:groovy:2.5.0
|    +--- org.codehaus.groovy:groovy-groovysh:2.5.0 <----------- HERE
|    |    +--- org.codehaus.groovy:groovy:2.5.0
|    |    +--- org.codehaus.groovy:groovy-cli-picocli:2.5.0
|    |    |    +--- org.codehaus.groovy:groovy:2.5.0
|    |    |    \--- info.picocli:picocli:3.0.2
|    |    +--- org.codehaus.groovy:groovy-console:2.5.0
|    |    |    +--- org.codehaus.groovy:groovy:2.5.0
|    |    |    +--- org.codehaus.groovy:groovy-cli-picocli:2.5.0 (*)
|    |    |    +--- org.codehaus.groovy:groovy-swing:2.5.0
|    |    |    |    \--- org.codehaus.groovy:groovy:2.5.0
|    |    |    \--- org.codehaus.groovy:groovy-templates:2.5.0
|    |    |         +--- org.codehaus.groovy:groovy:2.5.0
|    |    |         \--- org.codehaus.groovy:groovy-xml:2.5.0
|    |    |              \--- org.codehaus.groovy:groovy:2.5.0
|    |    \--- jline:jline:2.14.6
(...)

@codecov
Copy link

codecov bot commented Aug 28, 2018

Codecov Report

Merging #882 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #882      +/-   ##
============================================
- Coverage     75.03%   75.03%   -0.01%     
+ Complexity     3426     3423       -3     
============================================
  Files           368      368              
  Lines         10552    10545       -7     
  Branches       1333     1331       -2     
============================================
- Hits           7918     7912       -6     
  Misses         2167     2167              
+ Partials        467      466       -1
Impacted Files Coverage Δ Complexity Δ
...k-core/src/main/java/spock/lang/Specification.java 78.94% <0%> (-5.27%) 16% <0%> (-1%)
...k/runtime/extension/builtin/StepwiseExtension.java 90.47% <0%> (-0.83%) 8% <0%> (ø)
.../java/org/spockframework/runtime/SpockRuntime.java 71.73% <0%> (-0.43%) 20% <0%> (-3%)
...ckframework/spring/mock/DelegatingInterceptor.java 57.5% <0%> (+5%) 7% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47201d8...d5215d4. Read the comment docs.

@@ -25,7 +25,6 @@ ext {
minGroovyVersion = "2.5.2"
groovyDependency = [
"org.codehaus.groovy:groovy:${groovyVersion}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the coreConsole task depends on groovysh

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I've just reworked the approach to don't pollute the compile classpath.

It is needed only to start the Groovy console and should not pollute
the compile classpath.
@leonard84 leonard84 merged commit e757816 into spockframework:master Sep 9, 2018
MartyIX pushed a commit to MartyIX/spock that referenced this pull request Oct 14, 2018
It is needed only to start the Groovy console and should not pollute
the compile classpath.
@szpak szpak deleted the exclude-groovysh branch November 14, 2018 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants