-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude groovy-groovysh dependency #882
Conversation
f9f2905
to
766ac3b
Compare
Codecov Report
@@ Coverage Diff @@
## master #882 +/- ##
============================================
- Coverage 75.03% 75.03% -0.01%
+ Complexity 3426 3423 -3
============================================
Files 368 368
Lines 10552 10545 -7
Branches 1333 1331 -2
============================================
- Hits 7918 7912 -6
Misses 2167 2167
+ Partials 467 466 -1
Continue to review full report at Codecov.
|
766ac3b
to
c4783e6
Compare
@@ -25,7 +25,6 @@ ext { | |||
minGroovyVersion = "2.5.2" | |||
groovyDependency = [ | |||
"org.codehaus.groovy:groovy:${groovyVersion}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the coreConsole
task depends on groovysh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I've just reworked the approach to don't pollute the compile classpath.
It is needed only to start the Groovy console and should not pollute the compile classpath.
c4783e6
to
d5215d4
Compare
It is needed only to start the Groovy console and should not pollute the compile classpath.
It is needed only to start the Groovy console and should not pollute the compile classpath with the number of transitive dependencies: