Skip to content

Add :spock-specs:mock-integration subproject - #902

Merged
leonard84 merged 1 commit into
spockframework:masterfrom
marcphilipp:mock-integration-specs
Sep 11, 2018
Merged

Add :spock-specs:mock-integration subproject#902
leonard84 merged 1 commit into
spockframework:masterfrom
marcphilipp:mock-integration-specs

Conversation

@marcphilipp

Copy link
Copy Markdown
Member

The new project contains integration tests for using Spock to mock Java
interfaces/classes with cglib/byte-buddy and objenesis, and without any
of them.

In addition, the old testCglib task is removed because it is no longer
necessary to rerun all tests with byte-buddy deactivated.

@marcphilipp marcphilipp self-assigned this Sep 11, 2018
leonard84
leonard84 previously approved these changes Sep 11, 2018
@codecov

codecov Bot commented Sep 11, 2018

Copy link
Copy Markdown

Codecov Report

Merging #902 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #902      +/-   ##
============================================
- Coverage     75.02%   74.85%   -0.18%     
  Complexity     3426     3426              
============================================
  Files           368      368              
  Lines         10579    10579              
  Branches       1342     1342              
============================================
- Hits           7937     7919      -18     
- Misses         2168     2192      +24     
+ Partials        474      468       -6
Impacted Files Coverage Δ Complexity Δ
...spockframework/spring/UnwrapAopProxyExtension.java 31.81% <0%> (-45.46%) 2% <0%> (-2%)
...kframework/mock/runtime/ProxyBasedMockFactory.java 76.69% <0%> (-7.77%) 7% <0%> (+1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a463f1b...068757d. Read the comment docs.

@marcphilipp
marcphilipp force-pushed the mock-integration-specs branch 2 times, most recently from c92c82c to 068757d Compare September 11, 2018 15:06
The new project contains integration tests for using Spock to mock Java
interfaces/classes with cglib/byte-buddy and objenesis, and without any
of them.

The old testCglib task that reran all tests with byte-buddy
deactivated was removed except for spock-spring which contains a few
tests that only run when cglib is being used.
@marcphilipp
marcphilipp force-pushed the mock-integration-specs branch from 068757d to e0f0b67 Compare September 11, 2018 16:03
@leonard84
leonard84 merged commit ab43f8c into spockframework:master Sep 11, 2018
@marcphilipp
marcphilipp deleted the mock-integration-specs branch September 11, 2018 17:22
MartyIX pushed a commit to MartyIX/spock that referenced this pull request Oct 14, 2018
The new project contains integration tests for using Spock to mock Java
interfaces/classes with cglib/byte-buddy and objenesis, and without any
of them.

The old testCglib task that reran all tests with byte-buddy
deactivated was removed except for spock-spring which contains a few
tests that only run when cglib is being used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants