Separate code specific to cglib/ByteBuddy #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactoring commit extracts three top-level classes from `ProxyBasedMockFactory`: one for generating dynamic proxies for interfaces, one for cglib-specific code, and one for ByteBuddy-specific code.
Codecov Report
@@ Coverage Diff @@
## master #903 +/- ##
===========================================
- Coverage 75.03% 75% -0.03%
- Complexity 3429 3439 +10
===========================================
Files 368 371 +3
Lines 10579 10580 +1
Branches 1342 1337 -5
===========================================
- Hits 7938 7936 -2
- Misses 2171 2174 +3
Partials 470 470
Continue to review full report at Codecov.
|
marcphilipp
force-pushed
the
proxy-based-mock-factory-refactoring
branch
from
3a7b267
to
9296e9c
Compare
szpak
reviewed
Sep 11, 2018
| import static net.bytebuddy.matcher.ElementMatchers.any; | ||
| import static net.bytebuddy.matcher.ElementMatchers.none; | ||
|
|
||
| class ByteBuddyMockFactory { |
There was a problem hiding this comment.
+1 for keeping it package private
leonard84
approved these changes
Sep 11, 2018
MartyIX
pushed a commit
to MartyIX/spock
that referenced
this pull request
Oct 14, 2018
This refactoring commit extracts three top-level classes from `ProxyBasedMockFactory`: one for generating dynamic proxies for interfaces, one for cglib-specific code, and one for ByteBuddy-specific code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring commit extracts three top-level classes from
ProxyBasedMockFactory: one for generating dynamic proxies forinterfaces, one for cglib-specific code, and one for ByteBuddy-specific
code.