Add optional reason to @PendingFeature #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcphilipp
requested changes
Sep 13, 2018
| result.runCount == 1 | ||
| result.failureCount == 0 | ||
| result.ignoreCount == 0 | ||
| // unfortunately we can't access the skip reason here, but at least the branch is coverd |
| @@ -25,6 +27,7 @@ protected AssertionError featurePassedUnexpectedly() { | |||
| } | |||
|
|
|||
| protected AssumptionViolatedException assumptionViolation() { | |||
| return new AssumptionViolatedException("Feature not yet implemented correctly."); | |||
| return new AssumptionViolatedException("Feature not yet implemented correctly." | |||
| + ("".equals(reason) ? "" : "Reason: "+reason)); | |||
There was a problem hiding this comment.
If I'm not mistaken there's no space after the period now. It should be " Reason: ". Moreover spaces around the + would be more readable IMHO.
|
PTAL |
marcphilipp
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.