Repository navigation
Conversation
Codecov Report
@@ Coverage Diff @@
## master #956 +/- ##
============================================
+ Coverage 75.99% 75.99% +<.01%
- Complexity 3534 3544 +10
============================================
Files 377 377
Lines 10746 10788 +42
Branches 1367 1374 +7
============================================
+ Hits 8166 8198 +32
- Misses 2103 2109 +6
- Partials 477 481 +4
Continue to review full report at Codecov.
|
marcphilipp
reviewed
Nov 26, 2018
marcphilipp
left a comment
Member
There was a problem hiding this comment.
While I'm not familiar enough with the existing implementation to give it a thorough review, I really like the direction this is going as a user. 👍
leonard84
force-pushed
the
implicit-assertions-for-CodeArguments
branch
from
November 26, 2018 10:15
77b9007 to
cc9f260
Compare
leonard84
force-pushed
the
implicit-assertions-for-CodeArguments
branch
from
January 7, 2019 11:20
cc9f260 to
042482a
Compare
marcphilipp
reviewed
Jan 14, 2019
marcphilipp
left a comment
Member
There was a problem hiding this comment.
I really like the added documentation. 👍
However, I think a few more tests for the new behavior would be good or am I missing sth.?
leonard84
force-pushed
the
implicit-assertions-for-CodeArguments
branch
2 times, most recently
from
January 16, 2019 00:18
eb67fab to
ac5a6cc
Compare
leonard84
force-pushed
the
implicit-assertions-for-CodeArguments
branch
from
January 16, 2019 02:15
ac5a6cc to
b402b38
Compare
marcphilipp
approved these changes
Jan 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is