Skip to content

Add implicit assertions for CodeArgument constraints - #956

Merged
leonard84 merged 1 commit into
spockframework:masterfrom
leonard84:implicit-assertions-for-CodeArguments
Jan 22, 2019
Merged

leonard84 merged 1 commit into
spockframework:masterfrom
leonard84:implicit-assertions-for-CodeArguments

Conversation

@leonard84

@leonard84 leonard84 commented Nov 26, 2018 •

Copy link
Copy Markdown
Member

This change is Reviewable

@codecov

codecov Bot commented Nov 26, 2018 •

Copy link
Copy Markdown

Codecov Report

Merging #956 into master will increase coverage by <.01%.
The diff coverage is 83.67%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #956      +/-   ##
============================================
+ Coverage     75.99%   75.99%   +<.01%     
- Complexity     3534     3544      +10     
============================================
  Files           377      377              
  Lines         10746    10788      +42     
  Branches       1367     1374       +7     
============================================
+ Hits           8166     8198      +32     
- Misses         2103     2109       +6     
- Partials        477      481       +4
Impacted Files Coverage Δ Complexity Δ
...mework/mock/constraint/CodeArgumentConstraint.java 65% <54.54%> (-35%) 3 <2> (ø)
...g/spockframework/compiler/InteractionRewriter.java 70.71% <60%> (-0.47%) 50 <6> (+1)
...org/spockframework/compiler/DeepBlockRewriter.java 77.77% <96.96%> (+4.09%) 68 <14> (+9) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 528b25d...b402b38. Read the comment docs.

@marcphilipp marcphilipp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm not familiar enough with the existing implementation to give it a thorough review, I really like the direction this is going as a user. 👍

Comment thread spock-core/src/main/java/org/spockframework/compiler/DeepBlockRewriter.java Outdated
Comment thread spock-core/src/main/java/org/spockframework/compiler/DeepBlockRewriter.java Outdated
@leonard84
leonard84 force-pushed the implicit-assertions-for-CodeArguments branch from 77b9007 to cc9f260 Compare November 26, 2018 10:15
@leonard84
leonard84 force-pushed the implicit-assertions-for-CodeArguments branch from cc9f260 to 042482a Compare January 7, 2019 11:20

@marcphilipp marcphilipp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the added documentation. 👍

However, I think a few more tests for the new behavior would be good or am I missing sth.?

@leonard84
leonard84 force-pushed the implicit-assertions-for-CodeArguments branch 2 times, most recently from eb67fab to ac5a6cc Compare January 16, 2019 00:18
@leonard84 leonard84 changed the title WIP Add implicit assertions for CodeArgument constraints Add implicit assertions for CodeArgument constraints Jan 16, 2019
@leonard84
leonard84 force-pushed the implicit-assertions-for-CodeArguments branch from ac5a6cc to b402b38 Compare January 16, 2019 02:15
@leonard84
leonard84 merged commit 1a84301 into spockframework:master Jan 22, 2019
@leonard84
leonard84 deleted the implicit-assertions-for-CodeArguments branch January 22, 2019 02:22
mkutz pushed a commit to mkutz/spock that referenced this pull request May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants