Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make endopoints configurable. #4

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

darashi commented Jul 26, 2012

We are now developing Groonga CluodSearch, an open source implementation of Amazon CloudSearch.
http://gcs.groonga.org/

Groonga CloudSearch can work with aws_cloud_search by monkey patching
that directs the requests toward the host running Groonga CloudSearch instead of Amazon CloudSearch.
http://gcs.groonga.org/blog/2012/07/25/work-with-aws-cloud-search-gem/

It would be great if aws_cloud_search can pick the base domain name of doc and search endpoints and URL of configuration endpoint. With this patch, we can initiate AWSCloudSearch::CloudSearch object like below:

cloud_search = AWSCloudSearch::CloudSearch.new(
  'example-00000000000000000000000000',
  endpoint_base_domain: '127.0.0.1.xip.io:7575',
  configuration_url: 'http://localhost:7575'
)

How do you think? I'd like to hear your thought.

Member

djensen47 commented Aug 6, 2012

Yes, the endpoints should be more configurable. We will review your pull request.

darashi commented Oct 28, 2012

Are there any updates on this?

apsoto commented Oct 4, 2013

I'd like to comment that although it's 'nice' that the endpoint urls are 'derived' from some base value and you prepend 'search' and add the region and base AWS url, you should make the entire url configurable.

CloudSearch only allows IP based security, and our app runs on heroku which doesn't have a static ip. To work around it we are currently running our doc updates through a proxy with a static ip. Therefore, our doc upload url isn't even the standard url. Making the url configurable and allowing you to point to any url you want would be more flexible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment