[TASK] Finishs unit tests

Uses a helper variable to deactivate flashmessage saving in session which does not exist in phpunit Change-Id: Ic302dab9d3ca849647cbcaebc0687915ec472830
spoonerWeb · Dec 8, 2016 · 1ae37a6 · 1ae37a6
1 parent 1196990
commit 1ae37a6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/Classes/Evaluation/PasswordEvaluator.php b/Classes/Evaluation/PasswordEvaluator.php
@@ -42,9 +42,10 @@ public function returnFieldJS()
      * @param mixed $value The value that has to be checked.
      * @param string $is_in Is-In String
      * @param integer $set Determines if the field can be set (value correct) or not
+     * @param boolean $storeFlashMessageInSession Used only for phpunit issues
      * @return string The new value of the field
      */
-    public function evaluateFieldValue($value, $is_in, &$set)
+    public function evaluateFieldValue($value, $is_in, &$set, $storeFlashMessageInSession = true)
     {
         // if $value is a md5 hash, return the value directly
         if ($this->isMd5($value) || $this->isSalted($value)) {
@@ -164,7 +165,7 @@ public function evaluateFieldValue($value, $is_in, &$set)
                 implode(LF, $messages),
                 $languageService->getLL('messageTitle'),
                 \TYPO3\CMS\Core\Messaging\FlashMessage::ERROR,
-                true
+                $storeFlashMessageInSession
             )
         );
 

diff --git a/Tests/Unit/Evaluation/PasswordEvaluatorTest.php b/Tests/Unit/Evaluation/PasswordEvaluatorTest.php
@@ -148,7 +148,7 @@ public function checkForInvalidPassword(array $configuration, $password)
         $GLOBALS['TYPO3_CONF_VARS']['EXT']['extConf']['be_secure_pw'] = serialize($configuration);
         self::assertEquals(
             '',
-            $this->subject->evaluateFieldValue($password, '', $set)
+            $this->subject->evaluateFieldValue($password, '', $set, false)
         );
     }