This repository was archived by the owner on Jun 3, 2020. It is now read-only.
Fix import path resolve problem#27
Merged
Merged
Conversation
Contributor
Author
|
pypy flake8 단계에서 멈춰버리는데 제가 손대서 그런건 아닌 것 같습니다. pypy 5.6.0 기준으로는 flake8 통과하는 것 확인했습니다. |
Contributor
|
네 pypy쪽이 그런버그가 있어서 다른 프로젝트에선 패스한경우도있었네요. #26 의 경우 좋은 제안인것 같은데 이를 기본 옵션으로 적용하기보다는 따로 옵션을 주면 동작하도록 하는게 어떨까요? 기본옵션으로 이게 당장 들어간다면 현재 import-order 를 CI에서 적용하고있는 프로젝트는 버전을 올렸을때 전부다 깨질거같네요. |
Contributor
Author
|
네. CLI에서 별도 옵션을 주면 그것에 따라 동작이 바뀌도록 만들어 오겠습니다. |
Contributor
|
감사합니다! 방금 PR 하나 머지하면서 컨플릭도 생긴모양이네요.. |
Contributor
Author
|
@admire93 CI가 박살나있는걸 지금에서야 봤는데, 해당 버그 로컬에서 재현 안 됩니다. 아무래도 pytest 버전 등이 복합적으로 작용하는 것 같네요 |
Contributor
|
네 CI깨지는건 제가 별도로 보고 코드만 보면될것같습니다. 감사합니다. |
kanghyojun
approved these changes
Dec 18, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #26