Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it support SLP token? #31

Closed
Lafudoci opened this issue Apr 16, 2019 · 10 comments
Closed

Does it support SLP token? #31

Lafudoci opened this issue Apr 16, 2019 · 10 comments

Comments

@Lafudoci
Copy link

I'm implementing BCH and SLP token into my tipperbot. The part of BCH was done with this nice lib. However, I didn't figure out the way to get balance and make transaction of SLP token with this lib. If it's possible, could you elaborate how to do it? Thank you.

@merc1er
Copy link
Member

merc1er commented Apr 16, 2019

Bitcash doesn't seem to support SLP tokens at this point.

@ghost
Copy link

ghost commented Apr 16, 2019

Not familiar with SLP tokens, personally. There were some patches added for some kind of token-esque support. I've been pretty out of the loop on these new developments. May want to look through the recent pull requests and see if something you need is in master. I haven't cut a new release in a while.

@libercash
Copy link

The first issue adding SLP tokens support is output order. By default, Bitcash adds first the standard outputs and then messages. According to SLP token specification, the first output should be a OP_RETURN. Additional OP_RETURN outputs in M position could be needed (i.e Mint baton).

Changing sanitize_tx_data could be enough? The ideal could be passing an outputs list with mixed messages and P2PKH txs to create_transaction in the required order.

@ghost
Copy link

ghost commented Jun 27, 2019

Possibly, I've yet to look into this or any OP_RETURNs.

@Lafudoci
Copy link
Author

Lafudoci commented Apr 28, 2020

The first issue adding SLP tokens support is output order. By default, Bitcash adds first the standard outputs and then messages. According to SLP token specification, the first output should be a OP_RETURN. Additional OP_RETURN outputs in M position could be needed (i.e Mint baton).

Changing sanitize_tx_data could be enough? The ideal could be passing an outputs list with mixed messages and P2PKH txs to create_transaction in the required order.

I have tried to build SLP tx manually but no success. It seems the issue is on the outputs order and SLP address recognizing. But I don't have enough experience to imporve the code. Hope someone could help. SLP token is a promising feature to me.

@merc1er
Copy link
Member

merc1er commented Apr 28, 2020

SLP token is a promising feature to me.

I agree!

I will try to look into the SLP spec and the transaction part of the code. If someone wants to help with building SLP transactions, that would be awesome as I can easily take care of the balance and broadcast part of it.

@merc1er
Copy link
Member

merc1er commented Oct 6, 2020

This is being worked on 🚀

No ETA at this point, but a team of devs is looking into it.

@Lafudoci
Copy link
Author

Lafudoci commented May 9, 2021

This is being worked on

No ETA at this point, but a team of devs is looking into it.

Hi, any update here? NFT becomes really hot now. I really need this cool thing!

@merc1er
Copy link
Member

merc1er commented May 10, 2021

This is being worked on
No ETA at this point, but a team of devs is looking into it.

Hi, any update here? NFT becomes really hot now. I really need this cool thing!

maybe @nicolaiskye can give you an update on this

@merc1er
Copy link
Member

merc1er commented Jun 20, 2021

No support at this point, this is being worked on but no ETA.

@merc1er merc1er closed this as completed Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants