Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing missing encode component documentation entry #371

Conversation

charleystran
Copy link
Contributor

@charleystran charleystran commented Dec 23, 2019

Fixing the documentation to resolve #276 and add the missing docs entry for Addressable::URI.encode_component

@charleystran charleystran force-pushed the add_missing_encode_component_doc_entry branch from 52a500d to 48a02e2 Compare Dec 26, 2019
@charleystran
Copy link
Contributor Author

charleystran commented Dec 26, 2019

@sporkmonger any clue as to why the 2 jruby and truffelruby builds fail on this PR? The change is very small and I wouldnt expect it to break the builds. Any thoughts?

@dentarg
Copy link
Collaborator

dentarg commented Dec 26, 2019

@charleystran I guess they are unrelated. Last green build with truffleruby used 19.2.0 and the build here uses 19.3.0. Re: JRuby, bundle install fails. I suspect this is due to Bundler 2.1.2 is used, which is pretty new, so I rate the chance for a bug somewhere likely.

Feel free to report the errors to the projects, or look into if the CI setup here can be changed in some way to make it work. :)

@sporkmonger sporkmonger changed the base branch from master to main Jul 3, 2021
@sporkmonger sporkmonger merged commit bb03f71 into sporkmonger:main Jul 3, 2021
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants