Use the whole string instead of a single line for template match #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 2, 2021
ojab
force-pushed
the
ct-_do_not_parse_multiline_strings
branch
from
a2f32c7
to
22af13f
Compare
|
Marking as ready for review because |
therabidbanana
approved these changes
Sep 2, 2021
![github-code-scanning[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
spec/addressable/template_spec.rb
Dismissed
| @@ -77,6 +77,15 @@ | |||
| end | |||
| end | |||
|
|
|||
| describe "#to_regexp" do | |||
| it "does not match the first line of multiline strings" do | |||
| uri = "https://www.example.com/bar" | |||
Check failure
Code scanning / CodeQL
Incomplete regular expression for hostnames High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Multiline strings shouldn't pass the validation if a single line matches.