Compatibility fix of URI#hostname and URI#hostname= #89

Merged
merged 1 commit into from May 29, 2013

Conversation

Projects
None yet
3 participants
Contributor

nahi commented Oct 15, 2012

These methods works differently with URI#host and URI#host= for IPv6
address. Introduce method definitions from stdlib uri module for
compatibility.

Assigning bare IPv6 address via URI#host= should raise an exception but
this commit just adds a pending spec for compatibility concern. Can we
raise an exception as well as stdlib uri module?

@nahi nahi Compatibility fix of URI#hostname and URI#hostname=
These methods works differently with URI#host and URI#host= for IPv6
address.  Introduce method definitions from stdlib uri module for
compatibility.

Assigning bare IPv6 address via URI#host= should raise an exception but
this commit just adds a pending spec for compatibility concern.  Can we
raise an exception as well as stdlib uri module?
1b94abb
Owner

sporkmonger commented Oct 16, 2012

This looks pretty reasonable, though the difference is pretty subtle and I worry that may trip people up.

However, before I commit this, the docs need to be in YARD format.

+1 - ran into this issue recently

Owner

sporkmonger commented Feb 4, 2013

Any chance of the doc fix soon? I'd like to merge this.

sporkmonger merged commit 6b9b5f7 into sporkmonger:master May 29, 2013

1 check failed

default The Travis build failed
Details
Owner

sporkmonger commented May 29, 2013

Merging, going to make the doc fix myself.

@sporkmonger sporkmonger added a commit that referenced this pull request May 29, 2013

@sporkmonger sporkmonger Added changes from #89 to CHANGELOG. b56ad4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment