Skip to content

fix cucumber-rails integration and feature test #127

Merged
merged 1 commit into from Jun 29, 2011

2 participants

@stepheneb

See: https://github.com/timcharper/spork/issues/122

I did not commit the Gemfile.lock file used for generated rails3
application used for the cucumber-rails integration feature test.

This file does not affect the operation of spork and
will be re-generated whenever the Gemfile is updated and
the feature is run.

FYI: the following feature/scenarios fail on the master
branch both before and after this commit:

features/diagnostic_mode.feature:6
# Scenario: Running spork --diagnose

features/rails_delayed_loading_workarounds.feature:70
# Scenario: respecting custom autoload paths

@stepheneb stepheneb fix cucumber-rails integration and feature test
See: https://github.com/timcharper/spork/issues/122

I did not commit the Gemfile.lock file used for generated rails3
application used for the cucumber-rails integration feature test.

This file does not affect the operation of spork and
will be re-generated whenever the Gemfile is updated and
the feature is run. 

FYI: the following feature/scenarios fail on the master 
branch both before and after this commit:

  features/diagnostic_mode.feature:6 
  # Scenario: Running spork --diagnose
  
  features/rails_delayed_loading_workarounds.feature:70 
  # Scenario: respecting custom autoload paths
e72c77b
@stepheneb

There are more changes/updates that could be made to this file: https://github.com/timcharper/spork/blob/master/features/gemfiles/rails3.0/Gemfile ... rails 3.0.9, rspec 2.6 etc but I minimized the changes to those necessary to get cucumber-rails integration working again.

@stepheneb

Also ... before the changes to lib/spork/test_framework/cucumber.rb the changes to features/gemfiles/rails3.0/Gemfile caused the cucumber_rails_integration feature to fail.

I did not test and do not know if spork works with cucumber >= 0.9.0 and < 1.0.0 but I left the logic in to support the pre-existing pattern.

@timcharper timcharper merged commit 40c5962 into sporkrb:master Jun 29, 2011
@timcharper
sporkrb member

Thanks, Stephen! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.