Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

fix cucumber-rails integration and feature test #127

Merged
merged 1 commit into from

2 participants

@stepheneb

See: https://github.com/timcharper/spork/issues/122

I did not commit the Gemfile.lock file used for generated rails3
application used for the cucumber-rails integration feature test.

This file does not affect the operation of spork and
will be re-generated whenever the Gemfile is updated and
the feature is run.

FYI: the following feature/scenarios fail on the master
branch both before and after this commit:

features/diagnostic_mode.feature:6
# Scenario: Running spork --diagnose

features/rails_delayed_loading_workarounds.feature:70
# Scenario: respecting custom autoload paths

@stepheneb stepheneb fix cucumber-rails integration and feature test
See: https://github.com/timcharper/spork/issues/122

I did not commit the Gemfile.lock file used for generated rails3
application used for the cucumber-rails integration feature test.

This file does not affect the operation of spork and
will be re-generated whenever the Gemfile is updated and
the feature is run. 

FYI: the following feature/scenarios fail on the master 
branch both before and after this commit:

  features/diagnostic_mode.feature:6 
  # Scenario: Running spork --diagnose
  
  features/rails_delayed_loading_workarounds.feature:70 
  # Scenario: respecting custom autoload paths
e72c77b
@stepheneb

There are more changes/updates that could be made to this file: https://github.com/timcharper/spork/blob/master/features/gemfiles/rails3.0/Gemfile ... rails 3.0.9, rspec 2.6 etc but I minimized the changes to those necessary to get cucumber-rails integration working again.

@stepheneb

Also ... before the changes to lib/spork/test_framework/cucumber.rb the changes to features/gemfiles/rails3.0/Gemfile caused the cucumber_rails_integration feature to fail.

I did not test and do not know if spork works with cucumber >= 0.9.0 and < 1.0.0 but I left the logic in to support the pre-existing pattern.

@timcharper timcharper merged commit 40c5962 into sporkrb:master
@timcharper
Owner

Thanks, Stephen! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jun 28, 2011
  1. @stepheneb

    fix cucumber-rails integration and feature test

    stepheneb authored
    See: https://github.com/timcharper/spork/issues/122
    
    I did not commit the Gemfile.lock file used for generated rails3
    application used for the cucumber-rails integration feature test.
    
    This file does not affect the operation of spork and
    will be re-generated whenever the Gemfile is updated and
    the feature is run. 
    
    FYI: the following feature/scenarios fail on the master 
    branch both before and after this commit:
    
      features/diagnostic_mode.feature:6 
      # Scenario: Running spork --diagnose
      
      features/rails_delayed_loading_workarounds.feature:70 
      # Scenario: respecting custom autoload paths
This page is out of date. Refresh to see the latest.
View
2  Gemfile
@@ -1,5 +1,5 @@
source :gemcutter
-gem 'cucumber', '0.10.2'
+gem 'cucumber', '~> 1.0.0'
gem 'rspec', '~> 2.6'
gem 'rake'
View
10 Gemfile.lock
@@ -4,16 +4,16 @@ GEM
archive-tar-minitar (0.5.2)
builder (3.0.0)
columnize (0.3.2)
- cucumber (0.10.2)
+ cucumber (1.0.0)
builder (>= 2.1.2)
diff-lcs (>= 1.1.2)
- gherkin (>= 2.3.5)
+ gherkin (~> 2.4.1)
json (>= 1.4.6)
term-ansicolor (>= 1.0.5)
diff-lcs (1.1.2)
- gherkin (2.3.7)
+ gherkin (2.4.1)
json (>= 1.4.6)
- json (1.5.1)
+ json (1.5.3)
linecache19 (0.5.12)
ruby_core_source (>= 0.1.4)
rake (0.8.7)
@@ -41,7 +41,7 @@ PLATFORMS
ruby
DEPENDENCIES
- cucumber (= 0.10.2)
+ cucumber (~> 1.0.0)
rake
rspec (~> 2.6)
ruby-debug19
View
4 features/gemfiles/rails3.0/Gemfile
@@ -1,7 +1,7 @@
source :gemcutter
gem 'sqlite3-ruby', '1.2.5'
-gem 'cucumber', '0.10.2'
-gem 'cucumber-rails', '0.4.1'
+gem 'cucumber', '~> 1.0.0'
+gem 'cucumber-rails', '~> 1.0.0'
gem "rspec", "2.5.0"
gem 'rspec-rails', "2.5.0"
gem 'rails', '3.0.7'
View
4 lib/spork/test_framework/cucumber.rb
@@ -9,7 +9,7 @@ class << self
def preload
require 'cucumber'
- if ::Cucumber::VERSION >= '0.9.0'
+ if ::Cucumber::VERSION >= '0.9.0' && ::Cucumber::VERSION < '1.0.0'
# nothing to do nowadays
else
preload_legacy_cucumbers
@@ -18,7 +18,7 @@ def preload
end
def run_tests(argv, stderr, stdout)
- if ::Cucumber::VERSION >= '0.9.0'
+ if ::Cucumber::VERSION >= '0.9.0' && ::Cucumber::VERSION < '1.0.0'
::Cucumber::Cli::Main.new(argv, stdout, stderr).execute!
else
::Cucumber::Cli::Main.new(argv, stdout, stderr).execute!(@step_mother)
Something went wrong with that request. Please try again.