Kill all processes under JRuby/Windows #139

Merged
merged 1 commit into from Nov 8, 2011

Conversation

Projects
None yet
5 participants
@lstoldt
Contributor

lstoldt commented Sep 9, 2011

I'm noticing that when I run Spork under JRuby 1.6.4(ruby 1.9.2, rails 3.1) it creates a new jruby process every time I run my tests at the cost of about 100mb. In addition, these processes continue to run after I close spork with CTRL-C.

Attached a pull request that I'm currently using but couldn't run tests as they require linecache19 which has extensions which won't build under JRuby.

@kenmgrimm

This comment has been minimized.

Show comment Hide comment
@kenmgrimm

kenmgrimm Oct 27, 2011

Had the same problem with jruby / windows. Tried this patch and it works great, thanks!

Had the same problem with jruby / windows. Tried this patch and it works great, thanks!

@Vaysman

This comment has been minimized.

Show comment Hide comment
@Vaysman

Vaysman Oct 31, 2011

This patch help me too. Thanks.

Vaysman commented Oct 31, 2011

This patch help me too. Thanks.

@parndt

This comment has been minimized.

Show comment Hide comment
@parndt

parndt Nov 8, 2011

Seems like this could be pulled in @timcharper ?

parndt commented Nov 8, 2011

Seems like this could be pulled in @timcharper ?

timcharper added a commit that referenced this pull request Nov 8, 2011

Merge pull request #139 from lstoldt/master
Kill all processes under JRuby/Windows

@timcharper timcharper merged commit 5119287 into sporkrb:master Nov 8, 2011

@timcharper

This comment has been minimized.

Show comment Hide comment
@timcharper

timcharper Nov 8, 2011

Member

Patch looks good, sorry for the delay, thanks for the nudge. Merged.

Member

timcharper commented Nov 8, 2011

Patch looks good, sorry for the delay, thanks for the nudge. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment