diagnoser's load method signature does not match ruby's causing failure on Ruby 1.9.3 #170

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

pelle commented Jan 26, 2012

This is causing a failure at least in Ruby 1.9.3 and possibly earlier versions as well when doing spork -d

Just fixed the signature.

@pelle pelle diagnoser's load implementation does not have the same signature as i…
…n ruby.

This is causing a failure at least in Ruby 1.9.3 and possibly earlier versions as well when doing spork -d
4a9a778

I'm still getting an error even after I've upgraded to spork 1.0.0rc2:

$ spork -d
Using RSpec, Rails
Preloading Rails environment
Loading Spork.prefork block...
wrong number of arguments (2 for 1) (ArgumentError)
~/.rvm/gems/ruby-1.9.3-p125@mign/gems/spork-1.0.0rc2/lib/spork/diagnoser.rb:35:in `load'
~/.rvm/gems/ruby-1.9.3-p125@mign/gems/activesupport-3.2.1/lib/active_support/dependencies.rb:245:in `block in load'
~/.rvm/gems/ruby-1.9.3-p125@mign/gems/activesupport-3.2.1/lib/active_support/dependencies.rb:236:in `load_dependency'
~/.rvm/gems/ruby-1.9.3-p125@mign/gems/activesupport-3.2.1/lib/active_support/dependencies.rb:245:in `load'
~/.rvm/gems/ruby-1.9.3-p125@mign/gems/spork-1.0.0rc2/lib/spork/test_framework.rb:138:in `block (2 levels) in preload'
~/.rvm/gems/ruby-1.9.3-p125@mign/gems/spork-rails-3.2.0/lib/spork/app_framework/rails.rb:8:in `preload'
~/.rvm/gems/ruby-1.9.3-p125@mign/gems/spork-1.0.0rc2/lib/spork/test_framework.rb:134:in `block in preload'
~/.rvm/gems/ruby-1.9.3-p125@mign/gems/spork-1.0.0rc2/lib/spork.rb:62:in `exec_prefork'
~/.rvm/gems/ruby-1.9.3-p125@mign/gems/spork-1.0.0rc2/lib/spork/test_framework.rb:120:in `preload'
~/.rvm/gems/ruby-1.9.3-p125@mign/gems/spork-1.0.0rc2/lib/spork/runner.rb:69:in `run'
~/.rvm/gems/ruby-1.9.3-p125@mign/gems/spork-1.0.0rc2/lib/spork/runner.rb:10:in `run'
~/.rvm/gems/ruby-1.9.3-p125@mign/gems/spork-1.0.0rc2/bin/spork:10:in `<top (required)>'
~/.rvm/gems/ruby-1.9.3-p125@mign/bin/spork:19:in `load'
~/.rvm/gems/ruby-1.9.3-p125@mign/bin/spork:19:in `<main>'

maximeg commented Apr 6, 2012

Yeah, I just had this issue diagnosed.
And this commit is fine.

Contributor

sahilm commented Sep 14, 2013

Closing old pull requests. Please send new ones if this is still an issue.

sahilm closed this Sep 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment