Make max slaves number in magzine mode configurable #189

Closed
wants to merge 1 commit into
from

5 participants

@wpc

I am using spork for unit testing in a JRuby Rails project. I found the default 2 slaves in magazine mode is not big enough for a fast TDD rhythm. I frequently found I used up two of slave node and get a "- NO tuple" error. So I put in a environment variable called MAX_SLAVES to configure it(default is still 2). MAX_SLAVES=6 works perfectly for me.

@jarmo

I just started to do something similar, but i'd rename variable name to be more specific to spork, e.g. SPORK_MAX_SLAVES

@kevinzen

Any progress on this? I have an issue where I have my rspec prefork block load some singleton factories to prepopulate my test database with some data that a large number of my tests use. However, when two slaves both try to load it they step on each other and nothing works. So I want to have only one slave run. It doesn't look like there's any way to do this --

This pull request has been out there are year -- is anyone even maintaining spork anymore? The last update was 6 months ago.

@sahilm

Closing old pull requests. Please send new ones if this is still an issue.

@sahilm sahilm closed this Sep 14, 2013
@antonio

@sahilm this would indeed be a nice addition, as @wpc says 2 slaves may not be enough for some people's testing pace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment