Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't find a CONTRIBUTING.md so I tried to update the repository the best I could.
Few things to note:
elm-test
already comes with a Node runner so I removed the manual compilation to JSnpm test
,make test
there was also aprepare_test
file, so I got a bit confused. I tried to streamline the process the best I could with what the tools allow in their latest versionselm-format
on the repository to cleanup my changes but the latter formats to 4 spaces as indentation instead of the 2 configured here so I thought it best to not touch that partHttp.decodeUri
(and encode) now returning Maybes. I've just added a basicMaybe.withDefault ""
where relevant but you may have a better wayelm-test
generally, I've tried to update the test suite in a way that made sense but I think it could be cleaned up way more – I'm new to Elm but it appears a lot of the things you did manually (generating test suites and stuff) is now handled built-in byelm-test
so, might want to take a look at it