Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Operator and CRD related code #83

Merged
merged 5 commits into from Mar 19, 2020
Merged

Remove Operator and CRD related code #83

merged 5 commits into from Mar 19, 2020

Conversation

@slok
Copy link
Collaborator

slok commented Mar 19, 2020

This MR refactors the controller code of Kooper to make it simpler and remove the code related with the operator and CRD concepts.

Operator concept removed.

The concept of Operator in Kooper is simple, a controller and initialization of a resource. some time ago new tools started to arose to generate the CRD manifests easily, so you can register the CRD from a simple manifest outside the code. So knowing this, the need of initializing the CRD before starting the operator/controller is not required, the concept of the operator is not required anymore and only controller will be present in Kooper.

Changes on packages

Since the operator concept has been removed almost all the packages related with the controller have been changed, also, the handlers and retrievers have been merged on the same package to simplify.

Tracing

The tracing has been removed because it didn't add enough value on the controller side.

Defaults

Some controller defaults have been rethink to something more appropriate like the default resync interval.

Dependencies removed

Because we have removed the operator concept, the CRD concept and all the helpers related with this initialization we have removed the kubernetes/kubernetes dependency 馃帀 馃帀 馃帀

slok added 4 commits Mar 18, 2020
Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
@slok slok requested a review from ese as a code owner Mar 19, 2020
Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
@slok slok merged commit b97ec3f into spotahome:refactor Mar 19, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@slok slok deleted the slok:refactor branch Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can鈥檛 perform that action at this time.