Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with SQ 6.4 because of code colorizer API #84

Closed
dbmeneses opened this issue Mar 13, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@dbmeneses
Copy link

commented Mar 13, 2017

The code colorizer API (deprecated since 4.5.2) will be removed in SonarQube 6.4. More details here:
https://jira.sonarsource.com/browse/SONAR-7860

FindBugs plugin is currently still using it, which would make it incompatible with SonarQube 6.4. It should use directly the highlighting mechanism available in the SensorContext.

@h3xstream

This comment has been minimized.

Copy link
Member

commented Mar 15, 2017

@dbmeneses This could be the end of FindBugs support..
Unless SQ is providing a API that is similar..

@marschall

This comment has been minimized.

Copy link
Contributor

commented May 4, 2017

AFAIK this only affects JSP highlighting. How critical is that? Would you be willing to accept a PR that simply removes JSP highlighting?

marschall added a commit to marschall/sonar-findbugs that referenced this issue May 6, 2017

Remove JSP Colorizer
As the code colorizer API will be removed in SonarQube 6.4 this commit
removes the support for JSP colorization.

This is a simple fix for spotbugs#84

marschall added a commit to marschall/sonar-findbugs that referenced this issue May 6, 2017

Remove JSP Colorizer
As the code colorizer API will be removed in SonarQube 6.4 this commit
removes the support for JSP colorization.

This is a simple fix for spotbugs#84
@marschall

This comment has been minimized.

Copy link
Contributor

commented May 14, 2017

I believe this is fixed #93

@h3xstream

This comment has been minimized.

Copy link
Member

commented Jun 1, 2017

I will try to introduce an alternative in the next release. Otherwise, it may stay black on white for a while.

@h3xstream h3xstream closed this Jun 1, 2017

h3xstream added a commit that referenced this issue Jun 2, 2017

Merge pull request #104 from h3xstream/master
Add basic syntax highlighter #84

@h3xstream h3xstream modified the milestone: version-3.5 Jun 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.