New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a 2.x archetype rather than on old (1.x) Archetype (#6) #7

Merged
merged 1 commit into from Aug 8, 2017

Conversation

Projects
None yet
2 participants
@sewe
Contributor

sewe commented Aug 7, 2017

To do so, this change switches from the old archetype.xml to the new archetype-metadata.xml descriptor format.

Build a 2.x archetype rather than on old (1.x) Archetype (#6)
To do so, this change switches from the old archetype.xml to the
new archetype-metadata.xml descriptor format.

@sewe sewe requested a review from KengoTODA Aug 7, 2017

@KengoTODA

This comment has been minimized.

Show comment
Hide comment
@KengoTODA

KengoTODA Aug 8, 2017

Member

I will check. BTW where you find the information about archetype version 2? I found that offical site introduces only about version 1 format.

https://maven.apache.org/guides/mini/guide-creating-archetypes.html

Member

KengoTODA commented Aug 8, 2017

I will check. BTW where you find the information about archetype version 2? I found that offical site introduces only about version 1 format.

https://maven.apache.org/guides/mini/guide-creating-archetypes.html

@KengoTODA

I confirmed that generated project works as expected. Thank you!

@KengoTODA KengoTODA merged commit 7eecb63 into spotbugs:master Aug 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sewe

This comment has been minimized.

Show comment
Hide comment
@sewe

sewe Aug 8, 2017

Contributor

BTW where you find the information about archetype version 2? I found that offical site introduces only about version 1 format.

The version 2 format is documented here, alongside all other archetype-related XML vocabularies.

FWIW, updating the guide in the official site is bug ARCHETYPE-451 already.

Contributor

sewe commented Aug 8, 2017

BTW where you find the information about archetype version 2? I found that offical site introduces only about version 1 format.

The version 2 format is documented here, alongside all other archetype-related XML vocabularies.

FWIW, updating the guide in the official site is bug ARCHETYPE-451 already.

@sewe sewe deleted the sewe:issue-6 branch Aug 8, 2017

@KengoTODA

This comment has been minimized.

Show comment
Hide comment
@KengoTODA

KengoTODA Aug 8, 2017

Member

Good, thanks. I will check them.
If possible, we want to add one more source folder for case classes to separate test class and case class. I hope that v2 supports this requirement.

Member

KengoTODA commented Aug 8, 2017

Good, thanks. I will check them.
If possible, we want to add one more source folder for case classes to separate test class and case class. I hope that v2 supports this requirement.

@sewe

This comment has been minimized.

Show comment
Hide comment
@sewe

sewe Aug 8, 2017

Contributor

If possible, we want to add one more source folder for case classes to separate test class and case class. I hope that v2 supports this requirement.

I don’t this this has anything to do with the version; the archetype can put files in as many directories as you like. However, Maven traditionally supports only one ${project.build.sourceDirectory} and one ${project.build.testSourceDirectory} (see the POM Reference); if you want more than one test source directory, you will need the build-helper-maven-plugin.

Personally, I would simply use a different package, e.g., test.*, for the test data. (FYI, the test top-level domain is reserved by RFC 6761).

Contributor

sewe commented Aug 8, 2017

If possible, we want to add one more source folder for case classes to separate test class and case class. I hope that v2 supports this requirement.

I don’t this this has anything to do with the version; the archetype can put files in as many directories as you like. However, Maven traditionally supports only one ${project.build.sourceDirectory} and one ${project.build.testSourceDirectory} (see the POM Reference); if you want more than one test source directory, you will need the build-helper-maven-plugin.

Personally, I would simply use a different package, e.g., test.*, for the test data. (FYI, the test top-level domain is reserved by RFC 6761).

@KengoTODA

This comment has been minimized.

Show comment
Hide comment
@KengoTODA

KengoTODA Aug 8, 2017

Member

you will need the build-helper-maven-plugin.

Yes I know. In my understanding v1 let us use src/main/java and src/test/java but there is no option to add more like src/case/java, this is the problem what I faced.

About package, let's have separated discussion with @jsotuyod later.

Member

KengoTODA commented Aug 8, 2017

you will need the build-helper-maven-plugin.

Yes I know. In my understanding v1 let us use src/main/java and src/test/java but there is no option to add more like src/case/java, this is the problem what I faced.

About package, let's have separated discussion with @jsotuyod later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment